-
Notifications
You must be signed in to change notification settings - Fork 498
Fix page_count pragma #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix page_count pragma #2099
Conversation
0d6d908
to
948a5d9
Compare
0528a2a
to
cf4bb87
Compare
I think sqlite_schema initialization during page1 initialization makes intuitive sense. Do you want to do it here or leave it as a follow-up issue to be implemented by whoever? |
Let me take care of it here. |
I should note that most work of the Lines 1428 to 1439 in 46f5609
the remaining task is adding sqlite_schema table to Schema which occurs during Schema creation now.
|
Moving this logic to page1 initialization presents some difficulties:
|
cf4bb87
to
c48a5ef
Compare
Closes: #1415
What this PR does
read_tx
function..schema
,.indexes
,.tables
and.import
commands, as they rely onsqlite_schema
table.About the second issue
I think we have another solution for the second issue: create the
sqlite_schema
table inSchema
only during page1 initialization, rather than duringSchema
initialization.Pros
This approach has the advantage of unifying the logic for the
sqlite_schema
table with other user tables when runningselect
statementsCons
.schema
.pager
implementation.I'd like to hear your thoughts and feedback.