Improve ESLint rules #25146
Merged
Improve ESLint rules #25146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
reviewed
Dec 31, 2017
| @@ -324,10 +318,10 @@ const Dropdown = (($) => { | |||
|
|
|||
| const toggles = $.makeArray($(Selector.DATA_TOGGLE)) | |||
| for (let i = 0; i < toggles.length; i++) { | |||
| const parent = Dropdown._getParentFromElement(toggles[i]) | |||
| const context = $(toggles[i]).data(DATA_KEY) | |||
| const parent = Dropdown._getParentFromElement(toggles[i]) | |||
There was a problem hiding this comment.
Not big fan of this change 😟 but that's my personal feeling I think it's more readable like it was before that change
There was a problem hiding this comment.
Hmm, I didn't enforce any rules about spacing after =, so let me have a look again. I had enabled it at first but then dropped it.
Johann-S
approved these changes
Dec 31, 2017
XhmikosR
force-pushed
the
v4-dev-xmr-js-lint
branch
3 times, most recently
from
8ae834c to
b3a8cc6
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-js-lint
branch
from
b3a8cc6 to
097b420
Compare
Closed
Also, refactor ESLint and stylelint config files; now everything will work from our root dir.
XhmikosR
force-pushed
the
v4-dev-xmr-js-lint
branch
from
097b420 to
88e4eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about the new files, but this way one can run
eslint .and it will just work.