Conversation
julien-deramond
approved these changes
May 30, 2022
Member
There was a problem hiding this comment.
LGTM! 👌
IDK if anything must be done in the v5 migration guide. At the moment we have:
Collapse plugin now supports horizontal collapsing. — Add .collapse-horizontal to your .collapse to collapse the width instead of the height. Avoid browser repainting by setting a min-height or height.
Depending from which version you start and to which version you go you have several scenarios.
- v4 (<v4.7.0) → v5 (>=v5.1.0): Collapse plugin now supports horizontal collapsing
- v4.7.0 → v5.0.0: Collapse plugin doesn't exist anymore
- v4.7.0 → v5 (>=v5.1.0):
.widthmust be changed to.collapse-horizontal
mdo
force-pushed
the
v4-collapse-horizontal
branch
from
488ee2f to
4c06e34
Compare
This was referenced May 30, 2024
This was referenced Sep 23, 2024
This was referenced Sep 30, 2024
This was referenced Aug 19, 2025
This was referenced Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #34253 to v4. Changes the
collapse-horizontaltowidthfor those who've secretly been using this feature for years in Bootstrap 4 but never saw official support.