-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
Docs: missing aria-hidden on some decorative SVGs #40756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
86c97b0
bc3baf6
47785e5
dd14f57
d86fd32
40b5ee6
f004486
44f19a8
4debdf1
cd5b819
bdd3bfc
0c60b2d
96d99e6
36f255d
fe30d6f
cf2a08d
d848e9b
7edecfa
3b67c66
3375ade
dddafb9
006fcfa
958a6ce
705d6d6
69cfee7
354691b
bd52658
ff6a14c
99b527b
ba35585
fb24361
bfb9b8b
925119a
e0b937c
c1fb40f
9ced57e
ed27ce3
6c14139
a80793f
566d76a
00707f7
cc8f95d
301c64f
96553d7
fdb9157
b597ee2
6ded8cf
d7c1e4d
17fa427
4f01df6
8ecd6b7
42f65a1
ab90f5e
eda7447
0e1443e
41bd97e
27c568b
0512685
846c639
c324375
8f8ac5b
0304f82
2ee70cb
8664ebf
255f296
0bac1aa
2e1f116
44faa3f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,35 +66,35 @@ <h2 class="pb-2 border-bottom">Columns with icons</h2> | |
| <div class="row g-4 py-5 row-cols-1 row-cols-lg-3"> | ||
| <div class="feature col"> | ||
| <div class="feature-icon d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-2 mb-3"> | ||
| <svg class="bi" width="1em" height="1em"><use xlink:href="#collection"/></svg> | ||
| <svg class="bi" width="1em" height="1em" aria-hidden="true"><use xlink:href="#collection"/></svg> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note that
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (just as a heads-up before you laboriously go and add it to every, single, svg)
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for your answer :-) Our accessibility experts asked us to add aria-hidden on decorative SVGs in our Boosted doc, so I did it on Bootstrap when relevant. There aren't so much in the doc, but a lot more in the examples...! So if you're ok with this I can stop there and submit the PR?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wonder what the rationale provided by the accessibility experts there was. personally, I have no problem with having all the |
||
| </div> | ||
| <h3 class="fs-2 text-body-emphasis">Featured title</h3> | ||
| <p>Paragraph of text beneath the heading to explain the heading. We'll add onto it with another sentence and probably just keep going until we run out of words.</p> | ||
| <a href="#" class="icon-link"> | ||
| Call to action | ||
| <svg class="bi"><use xlink:href="#chevron-right"/></svg> | ||
| <svg class="bi"><use xlink:href="#chevron-right" aria-hidden="true"/></svg> | ||
| </a> | ||
| </div> | ||
| <div class="feature col"> | ||
| <div class="feature-icon d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-2 mb-3"> | ||
| <svg class="bi" width="1em" height="1em"><use xlink:href="#people-circle"/></svg> | ||
| <svg class="bi" width="1em" height="1em" aria-hidden="true"><use xlink:href="#people-circle"/></svg> | ||
| </div> | ||
| <h3 class="fs-2 text-body-emphasis">Featured title</h3> | ||
| <p>Paragraph of text beneath the heading to explain the heading. We'll add onto it with another sentence and probably just keep going until we run out of words.</p> | ||
| <a href="#" class="icon-link"> | ||
| Call to action | ||
| <svg class="bi"><use xlink:href="#chevron-right"/></svg> | ||
| <svg class="bi" aria-hidden="true"><use xlink:href="#chevron-right"/></svg> | ||
| </a> | ||
| </div> | ||
| <div class="feature col"> | ||
| <div class="feature-icon d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-2 mb-3"> | ||
| <svg class="bi" width="1em" height="1em"><use xlink:href="#toggles2"/></svg> | ||
| <svg class="bi" width="1em" height="1em" aria-hidden="true"><use xlink:href="#toggles2"/></svg> | ||
| </div> | ||
| <h3 class="fs-2 text-body-emphasis">Featured title</h3> | ||
| <p>Paragraph of text beneath the heading to explain the heading. We'll add onto it with another sentence and probably just keep going until we run out of words.</p> | ||
| <a href="#" class="icon-link"> | ||
| Call to action | ||
| <svg class="bi"><use xlink:href="#chevron-right"/></svg> | ||
| <svg class="bi" aria-hidden="true"><use xlink:href="#chevron-right"/></svg> | ||
| </a> | ||
| </div> | ||
| </div> | ||
|
|
@@ -107,7 +107,7 @@ <h2 class="pb-2 border-bottom">Hanging icons</h2> | |
| <div class="row g-4 py-5 row-cols-1 row-cols-lg-3"> | ||
| <div class="col d-flex align-items-start"> | ||
| <div class="icon-square text-body-emphasis bg-body-secondary d-inline-flex align-items-center justify-content-center fs-4 flex-shrink-0 me-3"> | ||
| <svg class="bi" width="1em" height="1em"><use xlink:href="#toggles2"/></svg> | ||
| <svg class="bi" width="1em" height="1em" aria-hidden="true"><use xlink:href="#toggles2"/></svg> | ||
| </div> | ||
| <div> | ||
| <h3 class="fs-2 text-body-emphasis">Featured title</h3> | ||
|
|
@@ -119,7 +119,7 @@ <h3 class="fs-2 text-body-emphasis">Featured title</h3> | |
| </div> | ||
| <div class="col d-flex align-items-start"> | ||
| <div class="icon-square text-body-emphasis bg-body-secondary d-inline-flex align-items-center justify-content-center fs-4 flex-shrink-0 me-3"> | ||
| <svg class="bi" width="1em" height="1em"><use xlink:href="#cpu-fill"/></svg> | ||
| <svg class="bi" width="1em" height="1em" aria-hidden="true"><use xlink:href="#cpu-fill"/></svg> | ||
| </div> | ||
| <div> | ||
| <h3 class="fs-2 text-body-emphasis">Featured title</h3> | ||
|
|
@@ -131,7 +131,7 @@ <h3 class="fs-2 text-body-emphasis">Featured title</h3> | |
| </div> | ||
| <div class="col d-flex align-items-start"> | ||
| <div class="icon-square text-body-emphasis bg-body-secondary d-inline-flex align-items-center justify-content-center fs-4 flex-shrink-0 me-3"> | ||
| <svg class="bi" width="1em" height="1em"><use xlink:href="#tools"/></svg> | ||
| <svg class="bi" width="1em" height="1em" aria-hidden="true"><use xlink:href="#tools"/></svg> | ||
| </div> | ||
| <div> | ||
| <h3 class="fs-2 text-body-emphasis">Featured title</h3> | ||
|
|
@@ -163,7 +163,7 @@ <h3 class="pt-5 mt-5 mb-4 display-6 lh-1 fw-bold">Short title, long jacket</h3> | |
| <small>Earth</small> | ||
| </li> | ||
| <li class="d-flex align-items-center"> | ||
| <svg class="bi me-2" width="1em" height="1em"><use xlink:href="#calendar3"/></svg> | ||
| <svg class="bi me-2" width="1em" height="1em" aria-hidden="true"><use xlink:href="#calendar3"/></svg> | ||
| <small>3d</small> | ||
| </li> | ||
| </ul> | ||
|
|
@@ -222,56 +222,56 @@ <h2 class="pb-2 border-bottom">Icon grid</h2> | |
|
|
||
| <div class="row row-cols-1 row-cols-sm-2 row-cols-md-3 row-cols-lg-4 g-4 py-5"> | ||
| <div class="col d-flex align-items-start"> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#bootstrap"/></svg> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#bootstrap"/></svg> | ||
| <div> | ||
| <h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3> | ||
| <p>Paragraph of text beneath the heading to explain the heading.</p> | ||
| </div> | ||
| </div> | ||
| <div class="col d-flex align-items-start"> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#cpu-fill"/></svg> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#cpu-fill"/></svg> | ||
| <div> | ||
| <h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3> | ||
| <p>Paragraph of text beneath the heading to explain the heading.</p> | ||
| </div> | ||
| </div> | ||
| <div class="col d-flex align-items-start"> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#calendar3"/></svg> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#calendar3"/></svg> | ||
| <div> | ||
| <h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3> | ||
| <p>Paragraph of text beneath the heading to explain the heading.</p> | ||
| </div> | ||
| </div> | ||
| <div class="col d-flex align-items-start"> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#home"/></svg> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#home"/></svg> | ||
| <div> | ||
| <h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3> | ||
| <p>Paragraph of text beneath the heading to explain the heading.</p> | ||
| </div> | ||
| </div> | ||
| <div class="col d-flex align-items-start"> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#speedometer2"/></svg> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#speedometer2"/></svg> | ||
| <div> | ||
| <h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3> | ||
| <p>Paragraph of text beneath the heading to explain the heading.</p> | ||
| </div> | ||
| </div> | ||
| <div class="col d-flex align-items-start"> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#toggles2"/></svg> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#toggles2"/></svg> | ||
| <div> | ||
| <h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3> | ||
| <p>Paragraph of text beneath the heading to explain the heading.</p> | ||
| </div> | ||
| </div> | ||
| <div class="col d-flex align-items-start"> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#geo-fill"/></svg> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#geo-fill"/></svg> | ||
| <div> | ||
| <h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3> | ||
| <p>Paragraph of text beneath the heading to explain the heading.</p> | ||
| </div> | ||
| </div> | ||
| <div class="col d-flex align-items-start"> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em"><use xlink:href="#tools"/></svg> | ||
| <svg class="bi text-body-secondary flex-shrink-0 me-3" width="1.75em" height="1.75em" aria-hidden="true"><use xlink:href="#tools"/></svg> | ||
| <div> | ||
| <h3 class="fw-bold mb-0 fs-4 text-body-emphasis">Featured title</h3> | ||
| <p>Paragraph of text beneath the heading to explain the heading.</p> | ||
|
|
@@ -296,7 +296,7 @@ <h2 class="fw-bold text-body-emphasis">Left-aligned title explaining these aweso | |
| <div class="row row-cols-1 row-cols-sm-2 g-4"> | ||
| <div class="col d-flex flex-column gap-2"> | ||
| <div class="feature-icon-small d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-4 rounded-3"> | ||
| <svg class="bi" width="1em" height="1em"> | ||
| <svg class="bi" width="1em" height="1em" aria-hidden="true"> | ||
| <use xlink:href="#collection" /> | ||
| </svg> | ||
| </div> | ||
|
|
@@ -306,7 +306,7 @@ <h4 class="fw-semibold mb-0 text-body-emphasis">Featured title</h4> | |
|
|
||
| <div class="col d-flex flex-column gap-2"> | ||
| <div class="feature-icon-small d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-4 rounded-3"> | ||
| <svg class="bi" width="1em" height="1em"> | ||
| <svg class="bi" width="1em" height="1em" aria-hidden="true"> | ||
| <use xlink:href="#gear-fill" /> | ||
| </svg> | ||
| </div> | ||
|
|
@@ -316,7 +316,7 @@ <h4 class="fw-semibold mb-0 text-body-emphasis">Featured title</h4> | |
|
|
||
| <div class="col d-flex flex-column gap-2"> | ||
| <div class="feature-icon-small d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-4 rounded-3"> | ||
| <svg class="bi" width="1em" height="1em"> | ||
| <svg class="bi" width="1em" height="1em" aria-hidden="true"> | ||
| <use xlink:href="#speedometer" /> | ||
| </svg> | ||
| </div> | ||
|
|
@@ -326,7 +326,7 @@ <h4 class="fw-semibold mb-0 text-body-emphasis">Featured title</h4> | |
|
|
||
| <div class="col d-flex flex-column gap-2"> | ||
| <div class="feature-icon-small d-inline-flex align-items-center justify-content-center text-bg-primary bg-gradient fs-4 rounded-3"> | ||
| <svg class="bi" width="1em" height="1em"> | ||
| <svg class="bi" width="1em" height="1em" aria-hidden="true"> | ||
| <use xlink:href="#table" /> | ||
| </svg> | ||
| </div> | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.