Skip to content

[Vblocks-4671] cypress device.ts #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: feature/test-runner-and-ts-upgrade
Choose a base branch
from

Conversation

kpchoy
Copy link
Collaborator

@kpchoy kpchoy commented May 29, 2025

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

https://twilio-engineering.atlassian.net/browse/VBLOCKS-4671

Description

Cypress e2e tests for:

  • Device
  • DeviceOptions

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Ready for review

Before merge

  • Got one or more +1s
  • Squashed erroneous commits if necessary
  • Re-tested if necessary

@kpchoy kpchoy changed the title [Vblocks 4671] cypress device.ts [Vblocks-4671] cypress device.ts May 29, 2025
@kpchoy kpchoy requested review from mhuynh5757 and charliesantos and removed request for mhuynh5757 and charliesantos May 29, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant