add missing dependencies for browsers #131
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this package is intended to be used in browsers it should not require node builtins.
Instead it should use browser compatible dependencies, e.g.:
If you try to use this package with a bundler (e.g. some Rollup setups, and Vite) that is strict about this sort of thing like you will be forced to workaround this issue.
I've also opened a PR on
twilio-video.js.Contributing to Twilio