Skip to content

Conversation

@DylanVann
Copy link

@DylanVann DylanVann commented Aug 19, 2020

If this package is intended to be used in browsers it should not require node builtins.

Instead it should use browser compatible dependencies, e.g.:

If you try to use this package with a bundler (e.g. some Rollup setups, and Vite) that is strict about this sort of thing like you will be forced to workaround this issue.

I've also opened a PR on twilio-video.js.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant