Skip to content

Create test/window directory and conftest file #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

mroeschke
Copy link
Collaborator

Precursor to #2

Copy link
Collaborator

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do this versus pandas/master. Best to push whatever we can there in small uncontroversial bits.


@pytest.fixture(
params=["sum", "mean", "median", "max", "min", "var", "std", "kurt", "skew"]
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a 1-line comment on each of these

@mroeschke
Copy link
Collaborator Author

Sounds good. I'll open this PR up against pandas/master instead.

@mroeschke mroeschke closed this Jul 8, 2019
@mroeschke
Copy link
Collaborator Author

Created pandas-dev#27305 with the first cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants