Skip to content

fix(twoslash-svelte): improve type resolving logic - #90

Merged
antfu merged 3 commits into
twoslashes:mainfrom
Hugos68:bugfix/improve-type-resolving
Jun 22, 2026
Merged

fix(twoslash-svelte): improve type resolving logic#90
antfu merged 3 commits into
twoslashes:mainfrom
Hugos68:bugfix/improve-type-resolving

Conversation

@Hugos68

@Hugos68 Hugos68 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

This PR fixes some initial issues around resolving the required types for svelte2tsx and removes the need for the peer dependency of svelte2tsx.

@netlify

netlify Bot commented Jun 6, 2026

Copy link
Copy Markdown

Deploy Preview for twoslash ready!

Name Link
🔨 Latest commit 5692d5a
🔍 Latest deploy log https://app.netlify.com/projects/twoslash/deploys/6a2407a2edbe3d00084301f5
😎 Deploy Preview https://deploy-preview-90--twoslash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Hugos68 Hugos68 changed the title bugfix/improve type resolving bugfix(twoslash-svelte): improve type resolving logic Jun 6, 2026
@codecov

codecov Bot commented Jun 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.50%. Comparing base (7765c5c) to head (5692d5a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files          17       17           
  Lines        1043     1043           
  Branches      332      333    +1     
=======================================
  Hits          944      944           
  Misses         93       93           
  Partials        6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hugos68

Hugos68 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

@antfu This PR is ready for review 🫡

@antfu antfu changed the title bugfix(twoslash-svelte): improve type resolving logic fix(twoslash-svelte): improve type resolving logic Jun 22, 2026
@antfu
antfu merged commit f86ad13 into twoslashes:main Jun 22, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants