5.2.3 regression with inference of models with custom `Manager` / `QuerySet`

[sobolevn]

Quoting @asottile-sentry from #2784 (comment)

Refs #2784

Quote starts:

---

I'm seeing a weird error here that I think is related? it seems to not be processing reverse model dependencies correctly?

src/sentry/releases/models.py:34: error: Cannot resolve keyword 'releasecommit' into field. Choices are: author, author_id, commitfilechange, date_added, date_created, id, key, message, organization_id, repository_id  [misc]

• https://github.com/getsentry/sentry/blob/e1829e8cbd0fe4179e137afbbee23b06d35d3eee/src/sentry/releases/models.py#L34
• https://github.com/getsentry/sentry/blob/e1829e8cbd0fe4179e137afbbee23b06d35d3eee/src/sentry/models/releasecommit.py#L20

---

also seems to not be processing _id automatic conversion:

src/sentry/users/models/user_option.py:62: error: Cannot resolve keyword 'project' into field. Choices are: id, key, organization_id, project_id, user, user_id, value  [misc]

• https://github.com/getsentry/sentry/blob/e1829e8cbd0fe4179e137afbbee23b06d35d3eee/src/sentry/users/models/user_option.py#L62
• https://github.com/getsentry/sentry/blob/e1829e8cbd0fe4179e137afbbee23b06d35d3eee/src/sentry/users/models/user_option.py#L204

[UnknownPlatypus]

I'm seeing a weird error here that I think is related? it seems to not be processing reverse model dependencies correctly?

i'll have a look tomorrow, seem like a bug indeed.

also seems to not be processing _id automatic conversion:

For this I think the error is expected (unless HybridCloudForeignKey is doing so additional magic) but for a regular foreignkey, it generates a field adding _id, but does not remove the prefix.

Here is what I tested:

class MyModel(models.Model):
    project_id = models.ForeignKey("sentry.Project", null=True, on_delete="CASCADE")


MyModel.objects.filter(project_id__isnull=True) # OK
MyModel.objects.filter(project_id_id__isnull=True) # OK
MyModel.objects.filter(project__isnull=True) # E: Cannot resolve keyword 'project' into field.

[asottile-sentry]

ah yep the id one is definitely just a latent bug:

(Pdb) UserOption.objects.unset_value(user=self.user, project=self.project, key='mail:email')
*** django.core.exceptions.FieldError: Cannot resolve keyword 'project' into field. Choices are: id, key, organization_id, project_id, user, user_id, value