BaseModelAdmin should be a generic class

[fancysnake]

Bug report

What's wrong

I have a class inheriting from BaseModelAdmin and a method delete_model defined as such:

def delete_model(self, request: HttpRequest, obj: AgendaItem) -> None:

AgendaItem is a Django model

However, mypy raises an error:

app/chronology/admin.py: note: In member "delete_model" of class "AgendaItemAdmin":
app/chronology/admin.py:376: error: Argument 2 of "delete_model" is
incompatible with supertype "ModelAdmin"; supertype defines the argument type as
"Model"  [override]
        def delete_model(self, request: HttpRequest, obj: AgendaItem) -> N...
        ^

because in stubs this function is defined as:

def delete_model(self, request: HttpRequest, obj: Model) -> None: ...

How is that should be

The solution is to make BaseModelAdmin a generic class with model type variable.

System information

• OS: ArchLinux
• python version: 3.8.6
• django version: 3.1.2
• mypy version: 0.782
• django-stubs version: 1.6.0

[sobolevn]

@radowit do you want to work on this?

[vgel]

I can take a shot at this!

[sobolevn]

@vgel awesome! Please, feel free to do so!

[vgel]

Unfortunately I've been really busy at work and don't think I can do this task at the moment. I'll try to come back to it later, but in the meantime if someone else wants to pick it up please feel free. Sorry!

…

On Mon, Oct 12, 2020 at 1:25 PM Nikita Sobolev ***@***.***> wrote: @vgel <https://github.com/vgel> awesome! Please, feel free to do so! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#482 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHPJACEIAPF7JJEDR2UEPLSKNQ3NANCNFSM4SLCO45A> .