Add missing methods to Field.
#100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurnikov
requested changes
Jul 8, 2019
| @@ -69,6 +69,10 @@ class Field(RegisterLookupMixin, Generic[_ST, _GT]): | |||
| def formfield(self, **kwargs) -> FormField: ... | |||
| def contribute_to_class(self, cls: Type[Model], name: str, private_only: bool = ...) -> None: ... | |||
| def to_python(self, value: Any) -> Any: ... | |||
| def get_attname(self) -> str: ... | |||
| def value_from_object(self, obj) -> _GT: ... | |||
There was a problem hiding this comment.
Could you extract this line (whuch causes test failures) in a different PR? It's probably not obvious of a change, and requires a test.
| @@ -69,6 +69,10 @@ class Field(RegisterLookupMixin, Generic[_ST, _GT]): | |||
| def formfield(self, **kwargs) -> FormField: ... | |||
| def contribute_to_class(self, cls: Type[Model], name: str, private_only: bool = ...) -> None: ... | |||
| def to_python(self, value: Any) -> Any: ... | |||
| def get_attname(self) -> str: ... | |||
| def value_from_object(self, obj) -> _GT: ... | |||
| def validate(self, value, model_instance) -> None: ... | |||
There was a problem hiding this comment.
Could you add annotations to the function arguments?
| def get_attname(self) -> str: ... | ||
| def value_from_object(self, obj) -> _GT: ... | ||
| def validate(self, value, model_instance) -> None: ... | ||
| def run_validators(self, value) -> None: ... |
There was a problem hiding this comment.
Same here, annotations for arguments
|
I addressed those in #109 |
voidus
pushed a commit
to voidus/django-stubs
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the following fields are missing from the base
Fieldclass:get_attname(https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L753)value_from_object(https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L892)validate(https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L592)run_validators(https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L576)