Skip to content

Makes localtime/localdate accept optional params #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2019
Merged

Makes localtime/localdate accept optional params #105

merged 2 commits into from
Jul 10, 2019

Conversation

sobolevn
Copy link
Member

Closes #104

mkurnikov
mkurnikov requested changes Jul 10, 2019
View reviewed changes
@mkurnikov mkurnikov merged commit f7db296 into master Jul 10, 2019
@sobolevn sobolevn deleted the issue-104 branch August 25, 2019 18:52
voidus pushed a commit to voidus/django-stubs that referenced this pull request Apr 23, 2024
Set correct types if upload_to is a function (typeddjango#105)
90bcc79 
https://docs.djangoproject.com/en/4.0/ref/models/fields/#django.db.models.FileField.upload_to

```python
        if callable(self.upload_to):
            filename = self.upload_to(instance, filename)
        else:
            dirname = datetime.datetime.now().strftime(str(self.upload_to))
            filename = posixpath.join(dirname, filename)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurnikov mkurnikov mkurnikov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First argument of localdate() and localtime() should be Optional
2 participants
@sobolevn @mkurnikov