fix classproperties in LiveServerTestCase #1288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes the classproperty decorator and expresses type hint as simple attribute instead this works because the two classproperty methods don't have any args so the classproperties actually behave like readonly arguments fixes #1285
|
Thanks! You created a PR just the same minute as I did, sorry for the duplicated work. #1287 implements a more general fix for classproperty decorator. |
|
better fix in #1287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the classproperty decorator
and expresses type hint as simple attribute instead
this works because the two classproperty methods don't have any args
so the classproperties actually behave like readonly arguments
fixes #1285