change render_to_string context type #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschoettle
force-pushed
the
render-to-string-context
branch
from
7a41139 to
9f0715d
Compare
sobolevn
reviewed
Dec 31, 2022
|
Thanks! |
This was referenced Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Change
contextargument ofrender_to_stringtodict[str, Any] | NoneThe documentation states for the
contextargumentSee: https://docs.djangoproject.com/en/dev/topics/templates/#django.template.loader.render_to_string
See: https://docs.djangoproject.com/en/dev/topics/templates/#django.template.engine.render_to_string
If I am misunderstanding anything with the change to
Mapping[_ContextKeys, ...]let me know please.Related issues
Refs #1298