Skip to content

Fix crash using .values_list("pk") on abstract model #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

flaeppe
Copy link
Member

@flaeppe flaeppe commented Jan 31, 2023

Related issues

Closes: #1347
Ref: #1328

@flaeppe flaeppe force-pushed the fix/abstract-values-list branch from b34d477 to 96ca4c3 Compare January 31, 2023 06:42
Copy link
Collaborator

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the test tweak, looks good to me.

@flaeppe flaeppe force-pushed the fix/abstract-values-list branch from 16a8ea2 to a5e4116 Compare February 7, 2023 20:46
@flaeppe flaeppe requested a review from intgr February 7, 2023 20:47
Copy link
Collaborator

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@intgr intgr merged commit 0bb7dbb into typeddjango:master Feb 7, 2023
@flaeppe flaeppe deleted the fix/abstract-values-list branch February 7, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Plugin crash on abstract model filtering with custom Manager
2 participants