Skip to content

Adds support for db_comment option on model fields and tests. #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2023
Merged

Adds support for db_comment option on model fields and tests. #1492

merged 2 commits into from
May 12, 2023

Conversation

andrlik
Copy link
Contributor

@andrlik andrlik commented May 11, 2023

Related issues

Adds support for Django 4.2's new option for model fields: db_comment. Adds a test for the same.

Format is:

sobolevn
sobolevn reviewed May 11, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But, we don't need tests for this:

  • Tests are quite slow to run
  • Change is very simple

@andrlik
Copy link
Contributor Author

andrlik commented May 12, 2023

Ok, I've removed the test case

@sobolevn
Copy link
Member

Thank you!

@sobolevn sobolevn merged commit 1efe9c6 into typeddjango:master May 12, 2023
This was referenced Apr 12, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model field arg db_comment not supported
2 participants
@andrlik @sobolevn