-
-
Notifications
You must be signed in to change notification settings - Fork 485
More fields #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More fields #15
Conversation
These are taken from the corresponding django/contrib/postgres/fields/ranges.py file.
DecimalField should subclass Field and not IntegerField, so i changed it. |
Unsure how to proceed with the lack of Psychopg stubs, we probably want stubs for the following two files at least: https://github.com/psycopg/psycopg2/blob/master/lib/extras.py and https://github.com/psycopg/psycopg2/blob/master/lib/_range.py, but unsure as to how this would be integrated. |
Shouldn't |
Probably, yes. I didn't really want to be maintaining a separate repo for stubs that I'd only consume through django-stubs, though. |
Can it be fixed with |
@mkurnikov updated with type: ignore for now. |
Thanks! |
This pr adds __get__ signatures for even more fields which are used in our codebase.