Various fixes for Django 4.2

[Alexerson]

I’m adding more Django 4.2 new types. I’m picking up the easier ones, and rather than having 5 one-line PR, I figured I would have them all in there. Let me know if you see things to fix I missed.

My strategy is to start from the stubgen output, so I’m also adding the new fields from 4.1 (or before) that are missing in the files I’m editing.

Related issues

• Refs Django 4.2 Tracking Issue #1519

[Alexerson]

I’m trying to improve the signature for NegatedExpression, but the current proposition is the best I can do, and it’s a bit disappointing. I’ll try again tomorrow if noone jumped in.

Also, I wanted Combinable.__invert__ to be -> NegatedExpression, because that would be logical with the implementation, but it causes all sort of issues that I don’t know how to fix.

[sobolevn]

Thanks!

We also tend to add "stub" generics to django-stubs-ext to monkeypatch them.

[Alexerson]

We also tend to add "stub" generics to django-stubs-ext to monkeypatch them.

Ok, I need to look into this.

[intgr]

Not to rush you, but I'd like to make a release soonish (#1550), and most changes in this MR look good.

Maybe we can defer NegatedExpression and ExpressionWrapper to a separate PR and merge this?

[Alexerson]

I'll have some time this morning. Either I finalize it, or I'll move it to a separate PR!

[Alexerson]

Ok, so I added some type: ignore. I believe they make sense. I’m not 100% sure how to add the generics to django-stubs-ext though, if someone can show me the way (maybe in another PR so we can close this?).

[intgr]

For monkeypatching you just need to add the classes to this list: https://github.com/typeddjango/django-stubs/blob/master/django_stubs_ext/django_stubs_ext/patch.py#L49-L74

[intgr]

Awesome! One minor issue, looks minor enough that I can apply the fix myself and then it's good to go.

[intgr]

If you do it like this, then the _E argument of ExpressionWrapper and _E argument of NegatedExpression won't be connected.

For example since .expression member comes from ExpressionWrapper

from django.db.models.expressions import NegatedExpression, Exists
x: NegatedExpression[Exists]
reveal_type(x.expression)  # note: Revealed type is "Any"

This fixes it:

Suggested change

	class NegatedExpression(ExpressionWrapper, Generic[_E]):
	class NegatedExpression(ExpressionWrapper[_E]):

[intgr]

This kind of mistake would be harder to make if we used disallow_any_generics (#1339)

[intgr]

Oof, this import will fail with Django 4.1 and earlier, since NegatedExpression class only appeared in 4.2.

Also we clearly have a blind spot in our CI since it didn't detect this.

@sobolevn Any ideas how to handle backwards compatibility in django-stubs-ext monkeypatching?

[intgr]

PR #1552 will add CI coverage for such surprises.

[intgr]

Anyway I'd remove NegatedExpression monkeypatching for now, to unblock this PR again.

I've created issue #1555 to solve it in the future.

[intgr]

Let's get this merged finally.