Add info about custom base models #181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurnikov
force-pushed
the
add-custom-base-model-to-readme
branch
from
1939640 to
c456680
Compare
|
I have some concerns with this solution, see #68 (comment) |
voidus
pushed a commit
to voidus/django-stubs
that referenced
this pull request
Apr 23, 2024
The way CPython works at runtime is to give a higher priority to the metaclass descriptors than the ones in the class itself. Pyright 1.1.324 adjusted that but made our `.objects` typing break when using our own custom managers. Nowadays we can use `Self` for that, which not only is more elegant but also solves this issue in a way that both mypy and pyright can resolve correctly. Related issues: - microsoft/pyright#5792 - microsoft/pyright#5686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68