Skip to content

Fix types for UniqueConstraint instantiation #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Fix types for UniqueConstraint instantiation #1880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d80f255
Fix types for UniqueConstraint instantiation
flaeppe Dec 16, 2023
7dd92a3
Merge branch 'master' into fix/unq-constraint
flaeppe Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions django-stubs/db/models/constraints.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class UniqueConstraint(BaseConstraint):
self,
*expressions: str | BaseExpression | Combinable,
fields: None = ...,
name: str,
name: str | None = ...,
condition: Q | None = ...,
deferrable: Deferrable | None = ...,
include: Sequence[str] | None = ...,
Expand All @@ -53,10 +53,12 @@ class UniqueConstraint(BaseConstraint):
self,
*,
fields: Sequence[str],
name: str,
name: str | None = ...,
condition: Q | None = ...,
deferrable: Deferrable | None = ...,
include: Sequence[str] | None = ...,
opclasses: Sequence[Any] = ...,
nulls_distinct: bool | None = ...,
violation_error_code: str | None = ...,
violation_error_message: _StrOrPromise | None = ...,
) -> None: ...
3 changes: 0 additions & 3 deletions scripts/stubtest/allowlist_todo.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,6 @@ django.contrib.gis.db.models.TimeField.formfield
django.contrib.gis.db.models.URLField.formfield
django.contrib.gis.db.models.UUIDField.class_lookups
django.contrib.gis.db.models.UUIDField.formfield
django.contrib.gis.db.models.UniqueConstraint.__init__
django.contrib.gis.db.models.UniqueConstraint.contains_expressions
django.contrib.gis.db.models.UniqueConstraint.validate
django.contrib.gis.db.models.Value.empty_result_set_value
Expand Down Expand Up @@ -1033,7 +1032,6 @@ django.db.models.TimeField.formfield
django.db.models.URLField.formfield
django.db.models.UUIDField.class_lookups
django.db.models.UUIDField.formfield
django.db.models.UniqueConstraint.__init__
django.db.models.UniqueConstraint.contains_expressions
django.db.models.UniqueConstraint.validate
django.db.models.Value.empty_result_set_value
Expand Down Expand Up @@ -1066,7 +1064,6 @@ django.db.models.constraints.BaseConstraint.contains_expressions
django.db.models.constraints.BaseConstraint.get_violation_error_message
django.db.models.constraints.BaseConstraint.validate
django.db.models.constraints.CheckConstraint.validate
django.db.models.constraints.UniqueConstraint.__init__
django.db.models.constraints.UniqueConstraint.contains_expressions
django.db.models.constraints.UniqueConstraint.validate
django.db.models.expressions.BaseExpression.empty_result_set_value
Expand Down