Skip to content

Conversation

@JaeHyuckSa
Copy link
Contributor

@JaeHyuckSa JaeHyuckSa commented May 5, 2024

I have made things!

While I was modifying the value for Any you mentioned in the PR #2123, I also modified the other functions the same because they looked the same code.

This list is a modification of argument for field, model, index.
  • django.db.backends.base.schema.BaseDatabaseSchemaEditor

    • django.db.backends.base.schema.BaseDatabaseSchemaEditor.skip_default
    • django.db.backends.base.schema.BaseDatabaseSchemaEditor.skip_default_on_alter
    • django.db.backends.base.schema.BaseDatabaseSchemaEditor.alter_db_table_comment
    • django.db.backends.base.schema.BaseDatabaseSchemaEditor.alter_db_tablespace
    • django.db.backends.base.schema.BaseDatabaseSchemaEditor.add_field
    • django.db.backends.base.schema.BaseDatabaseSchemaEditor.remove_field
  • django.db.backends.mysql.schema.DatabaseSchemaEditor

    • django.db.backends.mysql.schema.DatabaseSchemaEditor.skip_defaults
    • django.db.backends.mysql.schema.DatabaseSchemaEditor.add_field
  • django.db.backends.oracle.schema.DatabaseSchemaEditor

    • django.db.backends.oracle.schema.DatabaseSchemaEditor.remove_field
    • django.db.backends.oracle.schema.DatabaseSchemaEditor.delete_model
    • django.db.backends.oracle.schema.DatabaseSchemaEditor.alter_field
  • django.db.backends.postgresql.schema.DatabaseSchemaEditor

    • django.db.backends.postgresql.schema.DatabaseSchemaEditor.add_index
    • django.db.backends.postgresql.schema.DatabaseSchemaEditor.remove_index
  • django.contrib.gis.db.backends.mysql.schema. MySQLGISSchemaEditor

    • django.contrib.gis.db.backends.mysql.schema.MySQLGISSchemaEditor.skip_default
    • django.contrib.gis.db.backends.mysql.schema.MySQLGISSchemaEditor.column_sql
    • django.contrib.gis.db.backends.mysql.schema.MySQLGISSchemaEditor.create_model
    • django.contrib.gis.db.backends.mysql.schema.MySQLGISSchemaEditor.add_field
    • django.contrib.gis.db.backends.mysql.schema.MySQLGISSchemaEditor.remove_field
  • django.contrib.gis.db.backends.oracle.schema.OracleGISSchemaEditor

    • django.contrib.gis.db.backends.oracle.schema.OracleGISSchemaEditor.column_sql
    • django.contrib.gis.db.backends.oracle.schema.OracleGISSchemaEditor.create_model
    • django.contrib.gis.db.backends.oracle.schema.OracleGISSchemaEditor.delete_model
    • django.contrib.gis.db.backends.oracle.schema.OracleGISSchemaEditor.add_field
    • django.contrib.gis.db.backends.oracle.schema.OracleGISSchemaEditor.remove_field
  • django.contrib.gis.db.backends.sqlatialite.schema.SpatialiteSchemaEditor

    • django.contrib.gis.db.backends.sqlatialite.schema.SpatialiteSchemaEditor.column_sql
    • django.contrib.gis.db.backends.sqlatialite.schema.SpatialiteSchemaEditor.remove_geometry_metadata
    • django.contrib.gis.db.backends.sqlatialite.schema.SpatialiteSchemaEditor.create_model
    • django.contrib.gis.db.backends.sqlatialite.schema.SpatialiteSchemaEditor.delete_model
    • django.contrib.gis.db.backends.sqlatialite.schema.SpatialiteSchemaEditor.add_field
    • django.contrib.gis.db.backends.sqlatialite.schema.SpatialiteSchemaEditor.remove_field
    • django.contrib.gis.db.backends.sqlatialite.schema.SpatialiteSchemaEditor.alter_db_table
This list is a correction to the removal of None.
  • django.db.backends.base.schema.BaseDatabaseSchemaEditor.alter_db_table_comment's old_db_table_comment argument
This list is a variation of the type of str.
  • django.contrib.gis.db.backends.sqlatialite.schema.SpatialiteSchemaEditor.alter_db_tables old_db_table argument
  • django.contrib.gis.db.backends.sqlatialite.schema.SpatialiteSchemaEditor.alter_db_tables new_db_table argument
  • django.db.backends.base.schema.BaseDatabaseSchemaEditor.alter_db_tablespaces old_db_tablespace argument
  • django.db.backends.base.schema.BaseDatabaseSchemaEditor.alter_db_tablespaces new_db_tablespace argument

Related issues

Related PR

@JaeHyuckSa JaeHyuckSa changed the title Fix Any value for schemea Fix Any for schemea May 5, 2024
@JaeHyuckSa JaeHyuckSa changed the title Fix Any for schemea Fix Any value for schemea May 5, 2024
@JaeHyuckSa JaeHyuckSa changed the title Fix Any value for schemea Update Any value for schemea May 5, 2024
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit b0858a7 into typeddjango:master May 5, 2024
@intgr intgr changed the title Update Any value for schemea Improve typed in DB backend schema modules May 5, 2024
@intgr intgr changed the title Improve typed in DB backend schema modules Improve types in DB backend schema modules May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants