Don't populate a type arg for non generic managers#2314
Merged
flaeppe merged 2 commits intotypeddjango:masterfrom Aug 3, 2024
Merged
Don't populate a type arg for non generic managers#2314flaeppe merged 2 commits intotypeddjango:masterfrom
flaeppe merged 2 commits intotypeddjango:masterfrom
Conversation
sobolevn
reviewed
Aug 3, 2024
sobolevn
approved these changes
Aug 3, 2024
This was referenced Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We probably want a more sophisticated implementation of this to get things right when a type has multiple arguments, specifically bounded, etc. But as a first step, this can at least eliminate the obviously invalid ones.
Related issues
ClassVars #1672 (comment)