Fix GIS as_sql stub signatures to match runtime#3212
Open
ahmedasar00 wants to merge 3 commits intotypeddjango:masterfrom
Open
Fix GIS as_sql stub signatures to match runtime#3212ahmedasar00 wants to merge 3 commits intotypeddjango:masterfrom
ahmedasar00 wants to merge 3 commits intotypeddjango:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing
as_sqlmethod stubs to GIS modules.Changes
GeoFuncMixin.as_sqlstubArea.as_sqloverride stubLength.as_sqloverride stubRasterBandTransform.as_sqlstub# type: ignore[misc]to classes with MRO conflictsWhy
type: ignore[misc]?Django's
GeoFuncMixin.as_sqlintentionally narrows the signature fromFunc.as_sqlby removingtemplateandarg_joinerparameters. This causes MRO conflicts that are expected and safe to ignore.Refs allowlist_todo.txt entries:
django.contrib.gis.db.models.functions.Area.as_sqldjango.contrib.gis.db.models.functions.GeoFuncMixin.as_sqldjango.contrib.gis.db.models.functions.Length.as_sqldjango.contrib.gis.db.models.lookups.RasterBandTransform.as_sql