Fix mypy crash on QuerySet subclass with forward-referenced TypeVar#3241
Open
UnknownPlatypus wants to merge 1 commit intotypeddjango:masterfrom
Open
Fix mypy crash on QuerySet subclass with forward-referenced TypeVar#3241UnknownPlatypus wants to merge 1 commit intotypeddjango:masterfrom
UnknownPlatypus wants to merge 1 commit intotypeddjango:masterfrom
Conversation
…ound When a QuerySet subclass uses a forward-referenced TypeVar bound, the plugin generated an as_manager classmethod with unresolved placeholder types, causing mypy to crash with AssertionError: Must not defer during final iteration. The fix is to check for unresolved TypeVars before generating the method, and defer if any are found. Fixes typeddjango#2911
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to the plugin code change, a fresh mypy --strict tests/assert_type was crashing like so:
Fixes #2911