Skip to content

additional defer() to offset the effect of using the type before decl… #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 13, 2020
Merged

additional defer() to offset the effect of using the type before decl… #424

merged 5 commits into from
Jul 13, 2020

Conversation

kszmigiel
Copy link
Member

@kszmigiel kszmigiel requested review from mkurnikov and sobolevn July 12, 2020 11:16
@kszmigiel
Copy link
Member Author

@sobolevn @mkurnikov I'll create corresponding test later today

sobolevn
sobolevn approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's wait for the test case!

@kszmigiel
Copy link
Member Author

@sobolevn I think it's enough to check if it works properly, but I will wait for your opinion

@sobolevn sobolevn merged commit 92ef5d9 into typeddjango:master Jul 13, 2020
@sobolevn
Copy link
Member

Thanks a lot!

@kszmigiel kszmigiel mentioned this pull request Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@mkurnikov mkurnikov Awaiting requested review from mkurnikov

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AssertionError when using models.Manager
2 participants
@kszmigiel @sobolevn