Add algorithm parameter (Django 3.1) #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! I am going to leave this hanging for a while 😞 Please, see #262 |
sobolevn
approved these changes
Oct 14, 2020
|
@sobolevn I see. I also think there might be a problem around the versioning. Please leave it until the issue is resolved. |
|
@sobolevn I think it should be backwards compatible? The parameter is optional, the worst case will be a false-positive, which is fine. Right? Please merge it, if you agree with this. |
mkurnikov
changed the title
snejus
pushed a commit
to snejus/django-stubs
that referenced
this pull request
Mar 10, 2021
* add algorithm parameter * add algorithm field * reformat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
algorithmparameter or field, which is introduced in Django 3.1, to the following functions/classes:django.core.signing.Signer.__init__django.core.signing.base64_hmacdjango.utils.crypto.salted_hmacdjango.contrib.auth.tokens.PasswordResetTokenGeneratorRelated issues