Add attributes to the Model and Form classes (#83) #85
Conversation
* ModelForm could have 'Meta' inner class that references a model https://docs.djangoproject.com/en/2.2/topics/forms/modelforms/#modelform * And Model always have 'objects' field
| @@ -13,6 +13,7 @@ class Model(metaclass=ModelBase): | |||
| _meta: Any | |||
| _default_manager: Manager[Model] | |||
| pk: Any = ... | |||
| objects: Manager[Model] | |||
There was a problem hiding this comment.
Please, take a look at the https://github.com/mkurnikov/django-stubs/pull/20 and _default_manager in the Django docs. _default_manager is the reason why there's no objects attribute on the Model class.
There was a problem hiding this comment.
Um... then I don't understand. I should somehow define objects as alias to the _default_manager? Because if there is no objects then mypy will always fail in cases like mine...
There was a problem hiding this comment.
Maybe I can define objects and _default_manager as a TypeVar("_T", bound=Manager)? Will it be appropriate?
There was a problem hiding this comment.
You probably already know this, but just in case not, you can hint objects as objects: models.Manager and it will work generically for everything, though it won't be as specific as something like Manager[Model]. We use this in our codebase a lot.
|
I addressed |
This commit fixes type error in Model 'objects' (#83) and also adds 'Meta' inner class to the ModelForm, that is used to reference model and its fields (docs)