Tests: Fix compatbility with mypy 1.17 due to bump in django-stubs #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Jul 17, 2025
| # TODO: update our test error messages to match new mypy output | ||
| show_error_codes = false | ||
| force_uppercase_builtins = true | ||
| force_union_syntax = true |
There was a problem hiding this comment.
Suggested change
| force_union_syntax = true |
let's remove it as well.
There was a problem hiding this comment.
Agreed, I was planning to do it in a separate PR.
There was a problem hiding this comment.
Mypy version was bumped in django-stubs: * typeddjango/django-stubs#2744 The `force_uppercase_builtins` setting was deprecated in mypy 1.17. Caused test failures due to new logging. https://mypy.readthedocs.io/en/stable/changelog.html#deprecated-flag-force-uppercase-builtins
intgr
force-pushed
the
force_uppercase_builtins
branch
from
c28d821 to
7fb06e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy version was bumped in django-stubs:
The
force_uppercase_builtinssetting was deprecated in mypy 1.17. Caused test failures due to new logging.https://mypy.readthedocs.io/en/stable/changelog.html#deprecated-flag-force-uppercase-builtins