Can't use colon in output lines because item parsing is too greedy

[mjpieters]

The way that out lines are matched is not allowing for colons in the output message, because the severity group can capture up to the last colon in the message:

r"^(?P<fname>.*):(?P<lnum>\d*): (?P<severity>.*):((?P<col>\d+):)? (?P<message>.*)$"

Given a typical input with type annotations in a function:

main:2: note: Revealed type is def(foo: str) -> int

the severity group captures the text note: Revealed type is def(foo.

With more colons, the group ever expands; given

main:2: note: Revealed type is def(foo: str, bar: int, baz: float) -> int

the severity group matches note: Revealed type is def(foo: str, bar: int, baz.

See https://regex101.com/r/wOwuXG/1 for how the groups are filled.

Please match only non-colon text for severity:

(?P<severity>[^:]*)

to prevent this. See https://regex101.com/r/sM2uam/1 for a demo.

[mjpieters]

Here are two test-cases, that, when added to pytest_mypy_plugins/tests/test-regex-assertions.yml, should both pass:

- case: regex_against_callable_comment
  main: |
    def foo(bar: str, ham: int = 42) -> set[str | int]:
      return {bar, ham}
    reveal_type(foo)  # NR: Revealed type is "def \(bar: builtins\.str, ham: builtins\.int =\) -> .*"

- case: regex_against_callable_out
  regex: yes
  main: |
    def foo(bar: str, ham: int = 42) -> set[str | int]:
      return {bar, ham}
    reveal_type(foo)
  out: |
    main:3: note: Revealed type is "def \(bar: builtins\.str, ham: builtins\.int =\) -> .*"

However, the second case fails even though the regex is the same. Both pass when I replace (?P<severity>.*) with (?P<severity>[^:]+). Arguably the pattern should be tightened further, the severity is always expressed using ASCII letters only, for example.

I'll create a PR for this.