Skip to content

Ensure maps in parametrized sections are correctly extracted#181

Merged
sobolevn merged 1 commit into
typeddjango:masterfrom
alisaifee:fix-mappings-in-parametrized
Feb 16, 2026
Merged

Ensure maps in parametrized sections are correctly extracted#181
sobolevn merged 1 commit into
typeddjango:masterfrom
alisaifee:fix-mappings-in-parametrized

Conversation

@alisaifee

Copy link
Copy Markdown
Contributor

Description

When providing maps as a parametrized input, I noticed a __line__ key was being added to any entries and therefore changing the type of the input value from whatever I had to include "int" as a value.

Fix

As far as I could understand, the need for __line__ is only intended for the root mapping that contains the test case, thefore the "fix" is to only add the __line__ value to the mapping containing a case key. This is therefore not a "complete" fix since someone might actually have a parameter called case or containing a key called case.

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit 193a76f into typeddjango:master Feb 16, 2026
11 checks passed
@alisaifee alisaifee deleted the fix-mappings-in-parametrized branch February 16, 2026 13:51
@alisaifee

Copy link
Copy Markdown
Contributor Author

Thanks!

Thank you for the quick review/merge. Would it be possible to have a small release including this fix?

@sobolevn

Copy link
Copy Markdown
Member

Sure! Working on it #182

@sobolevn

Copy link
Copy Markdown
Member

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants