Fix leak of violations in site-packages#183
Merged
sobolevn merged 1 commit intoMar 12, 2026
Merged
Conversation
sobolevn
reviewed
Mar 11, 2026
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
Is there any way to test this? Or is it too complicated?
Member
Author
I think I can come up with something... But will need to finish off tomorrow. |
ngnpope
force-pushed
the
ngnpope/fix-site-package-leak
branch
2 times, most recently
from
49afe70 to
55cecd4
Compare
Member
Author
Scratch that - I got too absorbed so I've done it... I've come up with something that should hopefully work. Was a little bit awkward 😅 |
ngnpope
force-pushed
the
ngnpope/fix-site-package-leak
branch
from
55cecd4 to
3eb4f03
Compare
Makes the following changes to avoid third-party packages being treated as first-party packages which causes errors to be raised where those packages violate settings for mypy that are enabled in the stubs package: - Don't use `--no-silence-site-packages` by default - Don't add the test root path to `PYTHONPATH` Flags have been added that allow reverting to the previous behavior in case there are users of this plugin that depend on that behavior.
ngnpope
force-pushed
the
ngnpope/fix-site-package-leak
branch
from
3eb4f03 to
9df17fb
Compare
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the following changes to avoid third-party packages being treated as first-party packages which causes errors to be raised where those packages violate settings for mypy that are enabled in the stubs package:
--no-silence-site-packagesby defaultPYTHONPATHFlags have been added that allow reverting to the previous behavior in case there are users of this plugin that depend on that behavior.
Fixes #134