Docs/Tutorial -- Simplify Kleisli example#1588
Merged
Merged
Conversation
Amended second instance of parseAndReciprocal to use the same functions as in the earlier example.
Codecov Report
@@ Coverage Diff @@
## master #1588 +/- ##
=======================================
Coverage 92.42% 92.42%
=======================================
Files 249 249
Lines 3974 3974
Branches 138 138
=======================================
Hits 3673 3673
Misses 301 301Continue to review full report at Codecov.
|
peterneyens
approved these changes
Apr 4, 2017
Contributor
peterneyens
left a comment
There was a problem hiding this comment.
Thanks @RawToast, makes sense 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, I found the documentation to be a decent introduction to the concept -- so thanks!
I just found stating
Returning to our earlier exampleand then using a different solution to the earlier example be misleading -- I ended up scrolling up the page thinking I had missed a step!It would be clearer to use the same solution.