Conversation
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
=======================================
Coverage 93.88% 93.88%
=======================================
Files 246 246
Lines 4088 4088
Branches 154 155 +1
=======================================
Hits 3838 3838
Misses 250 250Continue to review full report at Codecov.
|
Contributor
Author
Contributor
|
@kailuowang thanks for this! Sorry, but I didn't see it until too late, and it has merge conflicts :( |
Contributor
Author
|
@ceedubs sorry for the delayed response. Conflicts resolved |
LukaJCB
approved these changes
Jan 5, 2018
Member
LukaJCB
left a comment
LukaJCB
left a comment
There was a problem hiding this comment.
This is great for clarification! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shall fix #334