Skip to content

temporarily disable MiMa check on kernel#1925

Merged
kailuowang merged 5 commits into
typelevel:masterfrom
kailuowang:disable-mima-kernel
Sep 28, 2017
Merged

temporarily disable MiMa check on kernel#1925
kailuowang merged 5 commits into
typelevel:masterfrom
kailuowang:disable-mima-kernel

Conversation

@kailuowang
Copy link
Copy Markdown
Contributor

temporarily disable to allow a couple of approved PRs (#1712 #1527) to pass build, should reenable after 1.0.0-RC1.
Also added QueueInstances and DurationInstances to all imports

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 22, 2017

Codecov Report

Merging #1925 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1925   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files         248      248           
  Lines        4430     4430           
  Branches      117      116    -1     
=======================================
  Hits         4233     4233           
  Misses        197      197

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664cb62...e8063c8. Read the comment docs.

@johnynek
Copy link
Copy Markdown
Contributor

johnynek commented Sep 22, 2017

can we not totally disable, and instead as people to add exceptions?

This prevents us from going hog-wild breaking things.

You can find notes:
https://github.com/typesafehub/migration-manager/wiki/Sbt-plugin#advanced-usage-filtering-binary-incompatibilities

@kailuowang
Copy link
Copy Markdown
Contributor Author

ah, then it probably makes more sense for those two PRs to add their own exceptions. I am going to add the exception for the all instance here.

@johnynek
Copy link
Copy Markdown
Contributor

yeah, I think each PR should add its own exception.

@kailuowang
Copy link
Copy Markdown
Contributor Author

updated. @johnynek

@johnynek
Copy link
Copy Markdown
Contributor

👍

This is great!

@johnynek johnynek mentioned this pull request Sep 28, 2017
@kailuowang kailuowang requested a review from LukaJCB September 28, 2017 12:18
@kailuowang
Copy link
Copy Markdown
Contributor Author

@LukaJCB do yo mind take a quick look at this one? would be nice to merge so other PRs can follow example without conflicts in the build.sbt.

Copy link
Copy Markdown
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge expert in this field, but it looks good to me!

@kailuowang kailuowang merged commit b785cd5 into typelevel:master Sep 28, 2017
@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants