Add a few type classes to generated tuple instances (continued) #1967
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1967 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 273 273
Lines 4541 4541
Branches 119 110 -9
=======================================
Hits 4363 4363
Misses 178 178Continue to review full report at Codecov.
|
LukaJCB
approved these changes
Oct 13, 2017
edmundnoble
approved these changes
Oct 18, 2017
Contributor
edmundnoble
left a comment
edmundnoble
left a comment
There was a problem hiding this comment.
Have you tested that the priority is correct, perhaps in the REPL? Otherwise 👍.
Contributor
Author
|
Yes @edmundnoble I tested in REPL . There is a separated issue for adding tests for generated coded #1968. We'll tackle the tests there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to finish up #1527 by
a) reorder the instance according to priority
b) added Mima rule exceptions, these changes were approved by @johnynek