CommutativeMonad for Eval#2103
Merged
Merged
Conversation
I believe (and the law tests seem to agree) that the existing monad instance for `Eval` is a valid `CommutativeMonad`, so we might as well expose it as one.
Codecov Report
@@ Coverage Diff @@
## master #2103 +/- ##
=======================================
Coverage 94.79% 94.79%
=======================================
Files 325 325
Lines 5490 5490
Branches 214 222 +8
=======================================
Hits 5204 5204
Misses 286 286
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Dec 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe (and the law tests seem to agree) that the existing monad
instance for
Evalis a validCommutativeMonad, so we might as wellexpose it as one.