Skip to content

Update deprecations to product{L,R} instead of ap{L,R}#2121

Merged
LukaJCB merged 5 commits into
typelevel:1.0from
rossabaker:purge-apL-and-apR
Dec 19, 2017
Merged

Update deprecations to product{L,R} instead of ap{L,R}#2121
LukaJCB merged 5 commits into
typelevel:1.0from
rossabaker:purge-apL-and-apR

Conversation

@rossabaker
Copy link
Copy Markdown
Member

No description provided.

ceedubs and others added 5 commits December 7, 2017 14:59
This makes it so when you look at the `Applicative` scaladoc you don't
have a bunch of `ap3`, `ap4`, etc noise mixed in with the more
meaningful methods. Instead, the generated higher-arity methods show up
in separate scaladoc groups below.

To see the changes you can pull this branch, run `sbt unidoc` (you may
need to clean first), and open
`cats/docs/target/scala-2.12/unidoc/cats/Applicative.html` in your
browser.
* Draft release notes

* Update

* Update

* Update

* Update

* Update

* Update Authors

* Update

* Update

* Update

* Update

* update

* Update

* Update CHANGES.md

* Update AUTHORS.md

* Update README.md
Add grouping to scaladoc for arity methods
@kailuowang
Copy link
Copy Markdown
Contributor

oops.

@rossabaker
Copy link
Copy Markdown
Member Author

I asked on cats-dev, should this have targeted the 1.0 branch?

Copy link
Copy Markdown
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@rossabaker rossabaker changed the base branch from master to 1.0 December 19, 2017 16:32
@rossabaker
Copy link
Copy Markdown
Member Author

Retarget to 1.0 pulled in other things already on cats master. Will cherry-pick and force-push.

@rossabaker
Copy link
Copy Markdown
Member Author

Never mind the cherry-pick-and-push-f. Discussed on cats-dev, and we want all these master changes back on 1.0 anyway.

@kailuowang kailuowang added this to the 1.0 milestone Dec 19, 2017
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 19, 2017

Codecov Report

Merging #2121 into 1.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              1.0    #2121   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files         328      328           
  Lines        5533     5533           
  Branches      199      199           
=======================================
  Hits         5238     5238           
  Misses        295      295
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/apply.scala 25% <ø> (ø) ⬆️
core/src/main/scala/cats/Apply.scala 75% <ø> (ø) ⬆️
core/src/main/scala/cats/Parallel.scala 88.46% <ø> (ø) ⬆️
core/src/main/scala/cats/FlatMap.scala 81.81% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b702ddc...0cb06f7. Read the comment docs.

@LukaJCB LukaJCB merged commit d421663 into typelevel:1.0 Dec 19, 2017
@stew stew removed the in progress label Dec 19, 2017
kailuowang added a commit that referenced this pull request Feb 2, 2018
* Setting version to 1.0.0-RC2

* Setting version to 1.0.0-SNAPSHOT

* Update deprecations to product{L,R} instead of ap{L,R} (#2121)

* Add grouping to scaladoc for arity methods

This makes it so when you look at the `Applicative` scaladoc you don't
have a bunch of `ap3`, `ap4`, etc noise mixed in with the more
meaningful methods. Instead, the generated higher-arity methods show up
in separate scaladoc groups below.

To see the changes you can pull this branch, run `sbt unidoc` (you may
need to clean first), and open
`cats/docs/target/scala-2.12/unidoc/cats/Applicative.html` in your
browser.

* Add doctest examples for Apply (#2086)

* Get ready for RC2 (#2044)

* Draft release notes

* Update

* Update

* Update

* Update

* Update

* Update Authors

* Update

* Update

* Update

* Update

* update

* Update

* Update CHANGES.md

* Update AUTHORS.md

* Update README.md

* Update deprecations to product{L,R} instead of ap{L,R}

* Setting version to 1.0.0

* Setting version to 1.0.1-SNAPSHOT

* Setting version to 1.0.1

* Setting version to 1.0.2-SNAPSHOT
@rossabaker rossabaker deleted the purge-apL-and-apR branch June 14, 2020 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants