Add jump start guide#2178
Conversation
|
@Andrea @kailuowang please take a look, that's basically the blog post https://virtuslab.com/blog/cats-library/, let me know if you think this needs any modifications |
Codecov Report
@@ Coverage Diff @@
## master #2178 +/- ##
=========================================
- Coverage 95.05% 94.96% -0.1%
=========================================
Files 333 333
Lines 5789 5799 +10
Branches 211 217 +6
=========================================
+ Hits 5503 5507 +4
- Misses 286 292 +6
Continue to review full report at Codecov.
|
|
Probably better that this PR is yours, I was basically re writing it, no point |
|
Hi @PawelLipski, does it make sense to update this to 1.0? I don't think having a jump start guide for 0.9 is in the best interest here if I'm being honest and I don't think anything that's particular to 0.9 from the code portion. Anyways thanks much for the great work! |
|
Thanks for the great work. To be honest, I am not sure how I feel about having |
|
@LukaJCB Sure, I'll migrate to 1.0.0... I'm sure the Cartesian syntax changed in the meantime, I'll check the other pieces as well. |
|
@LukaJCB I added a commit that migrates the guide to 1.0.1. In particular, I replaced |
|
Also, will soon link the new guide so that's accesible in the website. |
PawelLipski
force-pushed
the
jump-start-guide
branch
from
5e37a9b to
8844109
Compare
|
@Andrea @kailuowang @LukaJCB I fixed all the issues the I could see so far, pls review |
| lazy val catsSettings = commonSettings ++ publishSettings ++ scoverageSettings ++ javadocSettings | ||
|
|
||
| lazy val scalaCheckVersion = "1.13.5" | ||
| lazy val scalaMockVersion = "3.6.0" |
There was a problem hiding this comment.
Is it just me that finds mocks (in a functional context) a bit of a flag for things that could be improved? I can see why you are adding this here, at the same time...I have reservations for the same reason the Future was mentioned in another comment.
If it was me, I would go with a simplified implementation for the purposes of this example (this is why I was re writing a lot of the examples)
There was a problem hiding this comment.
I fully agree, I think Future is good as a gateway drug, but I'm not sure we should encourage mocks. :)
There was a problem hiding this comment.
Okey, fixing now
|
@Andrea @kailuowang @LukaJCB removed mentions of mocks |
|
Thanks very much! This is looking good. We need a link to it, how about an entry close to the top in the FAQs LIst? |
|
@kailuowang well... I actually added a link to that to the main menu but not sure not if it's not an overkill :) Please let me know if you can see a better place for that... |
|
I propose we add it as a new FAQ question and place it second on the list (after what import do I need). |
|
Okey, I added to FAQ as suggested and removed from main menu. It's not linked now from anywhere else but that FAQ answer, though. |
|
@kailuowang do you see any outstanding issues with this PR or can we think of merging? Recent travis fail is apparently due to some OOM... https://api.travis-ci.org/v3/job/374505453/log.txt |
LukaJCB
left a comment
LukaJCB
left a comment
There was a problem hiding this comment.
Thank you! And sorry for the delay! :)
|
@LukaJCB can you merge? ;) or is there anything specific that holds us back from merging? ^^ |
|
I keep saying this, but yeah sorry for the delay and thanks for your work! It is appreciated! :) |
|
No problem and thank you! :) When (circa) is it going to be published on the website? I guess that's gonna be included in some 1.1.1/1.2.0 right? |
5 participants
No description provided.