Add parTuple#2183
Conversation
|
This is awesome :-) could you maybe keep it as |
|
absolutely right, I will change it. Thanks |
Codecov Report
@@ Coverage Diff @@
## master #2183 +/- ##
=======================================
Coverage 94.75% 94.75%
=======================================
Files 330 330
Lines 5568 5568
Branches 201 207 +6
=======================================
Hits 5276 5276
Misses 292 292
Continue to review full report at Codecov.
|
| | * @groupdesc ParTupleArity Higher-arity parTuple methods | ||
| | * @groupprio ParTupleArity 999 | ||
| | */ | ||
| |trait ParallelArityFunctions2 { |
There was a problem hiding this comment.
If we make this one an abstract class then we can add more methods in the future without breaking bin compat.
There was a problem hiding this comment.
sure, changed. To avoid problems mixing in the two with Parallel I extended ParallelArityFunctions with ParallelArityFunctions2. Do you think this will prevent from adding methods in the future ? Thanks
|
It looks like there are some memory issues in the CI. Do I have ways to trigger it again ? I think it should pass, I checked MiMa locally and should be fine. |
|
Thanks very much for this @barambani! Just a tiny last request, can we add some sort of test for this? I'm pretty confident this works as is, but should we ever change anything it'd be good to have that extra test :) |
|
Thank you all |
|
Sorry I missed the edit. I will add the tests 👍 |
|
Thank you gents for the help 👍 |
5 participants
As from the discussion in here #2128 this and attempt to add parTuple syntax in a way that preserves backwards binary compatibility.