Add "Law Testing" to side menu to increase visiblity.#2196
Merged
Conversation
Laws are important and the link to the Law Testing page is quite hidden (in a hyperlink all the way down the bottom of the Typeclasses page). I suspect making it more visible might encourage more people to learn how to test typeclass laws.
Codecov Report
@@ Coverage Diff @@
## master #2196 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 332 332
Lines 5697 5697
Branches 214 212 -2
=======================================
Hits 5400 5400
Misses 297 297Continue to review full report at Codecov.
|
LukaJCB
approved these changes
Mar 16, 2018
Member
ChristopherDavenport
left a comment
ChristopherDavenport
left a comment
There was a problem hiding this comment.
Definitely 👍 One of the things I am frequently asked about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laws are important and the link to the Law Testing page is quite hidden (in a hyperlink all the way down the bottom of the Typeclasses page). I suspect making it more visible might encourage more people to learn how to test typeclass laws.
Here's a screenshot on how it would look: