Update state.md#2248
Merged
Merged
Conversation
I think functions `open` and `close` were swapped in section about `IndexedStateT`.
Codecov Report
@@ Coverage Diff @@
## master #2248 +/- ##
==========================================
+ Coverage 94.65% 94.97% +0.32%
==========================================
Files 333 337 +4
Lines 5777 5832 +55
Branches 217 217
==========================================
+ Hits 5468 5539 +71
+ Misses 309 293 -16
Continue to review full report at Codecov.
|
johnynek
reviewed
May 6, 2018
Contributor
johnynek
left a comment
There was a problem hiding this comment.
Can we change the tut to actually catch this error? Like it we had run open against an Open door, it should have failed. Can we add positive and negative examples of that now and make sure tut catches the issue?
Contributor
Author
|
I'm really sorry for such late response. I've added code which tries to run |
kailuowang
approved these changes
Jun 11, 2018
Contributor
|
Thanks @rsekulski! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think functions
openandclosewere swapped in section aboutIndexedStateT.