Add Function To Check All Relevant MiMa Versions#2265
Conversation
| else List(minor) | ||
| val patchVersions: List[Int] = | ||
| if (minor == 0 || patch == 0) List.empty[Int] | ||
| else Range(0, patch - 1).inclusive.toList |
There was a problem hiding this comment.
hmmm, I wonder if this would work. Your patchVersions is derived from the current major.minor.patch range, but you don't know if your previous minor version's patch range right?
e.g. if the current version is 1.1.0, you wouldn't check against 1.0.1? or if the current version is 1.1.3-SNAPSHOT, your list would include 1.0.2 which doesn't exist. Another issue is that if either if the current patch is 0, you wouldn't check against anything, e.g. 1.2.0-SNAPSHOT wouldn't check mima, right?
There was a problem hiding this comment.
This is why I knew this would be the place. 😄
edit: Your right I could only check the .0 for min versions different than the current version.
Codecov Report
@@ Coverage Diff @@
## master #2265 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 334 334
Lines 5801 5801
Branches 214 215 +1
=======================================
Hits 5509 5509
Misses 292 292Continue to review full report at Codecov.
|
kailuowang
left a comment
kailuowang
left a comment
There was a problem hiding this comment.
Looking good to me. Thanks!
4 participants
Removes Need for Manually Setting Binary Compatible Versions