Update Bitraverse docs #2291
Merged
Merged
Conversation
Contributor
Zelenya
commented
Jun 10, 2018
- update bisequence doc (not sure if it got any better)
- add bitraverse doctest example
Codecov Report
@@ Coverage Diff @@
## master #2291 +/- ##
==========================================
+ Coverage 94.97% 95.01% +0.03%
==========================================
Files 337 337
Lines 5832 5832
Branches 217 217
==========================================
+ Hits 5539 5541 +2
+ Misses 293 291 -2
Continue to review full report at Codecov.
|
ceedubs
approved these changes
Jun 11, 2018
Contributor
ceedubs
left a comment
There was a problem hiding this comment.
Thanks @Zelenya!
I could see there being some merit in using different types instead of both inputs being Int and both outputs being Option[Int] to make it clear that this works on different types. But I think that this is a simple example and it's a nice addition.
Contributor
Author
|
@ceedubs yeah, I've initially did |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.