Skip to content

Fix repetition in NonEmptyChain scala docs#2803

Merged
kailuowang merged 1 commit into
typelevel:masterfrom
Obarros:2802-fix-NonEmptyChain-scaladocs
Apr 22, 2019
Merged

Fix repetition in NonEmptyChain scala docs#2803
kailuowang merged 1 commit into
typelevel:masterfrom
Obarros:2802-fix-NonEmptyChain-scaladocs

Conversation

@Obarros
Copy link
Copy Markdown
Contributor

@Obarros Obarros commented Apr 21, 2019

This will update the scaladocs for NonEmptyChain.
The same example was used for reduceRightTo and reduceLeftTo method.
Fix #2803

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 21, 2019

Codecov Report

Merging #2803 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2803   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files         368      368           
  Lines        6914     6914           
  Branches      296      296           
=======================================
  Hits         6510     6510           
  Misses        404      404
Impacted Files Coverage Δ
core/src/main/scala/cats/data/NonEmptyChain.scala 98.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b562a8...3ec8426. Read the comment docs.

Copy link
Copy Markdown
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks Ozias :)

Copy link
Copy Markdown
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was puzzled how the original example worked. Then I realized that it's the any2stringadd

@kailuowang kailuowang merged commit 16a38cb into typelevel:master Apr 22, 2019
@kailuowang kailuowang added this to the 2.0.0-M1 milestone Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants