Implement LazyList tailRecM using Iterator.unfold#2964
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2964 +/- ##
==========================================
+ Coverage 93.91% 93.93% +0.02%
==========================================
Files 371 371
Lines 7061 7061
Branches 177 177
==========================================
+ Hits 6631 6633 +2
+ Misses 430 428 -2
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2964 +/- ##
==========================================
+ Coverage 93.91% 93.93% +0.02%
==========================================
Files 371 371
Lines 7061 7061
Branches 177 177
==========================================
+ Hits 6631 6633 +2
+ Misses 430 428 -2
Continue to review full report at Codecov.
|
rossabaker
approved these changes
Aug 2, 2019
johnynek
reviewed
Aug 5, 2019
| val b = o.get | ||
| advance() | ||
| b | ||
| val kernel = Iterator.unfold[Option[B], Iterator[Either[A, B]]](Iterator(Left(a))) { it => |
Contributor
There was a problem hiding this comment.
two small notes, I bet this would be faster if we did:
unfold[Option[B], List[Iterator[Either[A, B]]])(Iterator.single(Left(a)) :: Nil) {
case Nil => None
case nonempty@(h :: t) =>
if (!h.hasNext) Some((None, t))
else h.next match {
case Left(a) => Some((None, fn(a) :: nonempty))
case Right(b) => Some((Some(b), nonempty))
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
LazyList'stailRecMusingIterator.unfold.