Update Semigroup docs for Map#3071
Merged
Merged
Conversation
I didn't understand that the values in Maps were also combined when two maps are combined - I thought the `"hello" -> 2` entry was simply _replacing_ the `"hello" -> 0` entry in the first map. Giving the first map's `"hello"` a value of `1` results in the combined map having a `"hello" -> 3` entry, showing that the values were combined. After understanding that, I realized why my code couldn't find an implicit `Semigroup` for my Map - I didn't have an implicit `Semigroup` for my map's values.
LukaJCB
approved these changes
Sep 18, 2019
Member
LukaJCB
left a comment
There was a problem hiding this comment.
Thanks, this does make it a bit easier to see what's going on :)
kailuowang
approved these changes
Sep 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #3071 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 368 368
Lines 6979 6979
Branches 184 184
=======================================
Hits 6523 6523
Misses 456 456Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't understand that the values in Maps were also combined when two maps are combined - I thought the
"hello" -> 2entry was simply replacing the"hello" -> 0entry in the first map. Giving the first map's"hello"a value of1results in the combined map having a"hello" -> 3entry, showing that the values were combined.After understanding that, I realized why my code couldn't find an implicit
Semigroupfor my Map - I didn't have an implicitSemigroupfor my map's values.Thank you for contributing to Cats!
This is a kind reminder to run
sbt prePRand commit the changed files, if any, before submitting.