Deprecate and make private syntax methods that are now on Either#3149
Merged
LukaJCB merged 1 commit intoNov 14, 2019
Merged
Conversation
LukaJCB
approved these changes
Nov 14, 2019
fthomas
approved these changes
Nov 14, 2019
LukaJCB
approved these changes
Nov 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #3149 +/- ##
==========================================
- Coverage 93.28% 93.21% -0.07%
==========================================
Files 376 376
Lines 7323 7323
Branches 195 195
==========================================
- Hits 6831 6826 -5
- Misses 492 497 +5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of these methods are available directly on
Eithernow that we've dropped 2.11. We could probably just deprecate them to discourage explicit usage but I package-privated them as well since it might have some tiny effect on compile times.