Enable and fix doctests on 2.13#3155
Merged
LukaJCB merged 2 commits intoDec 10, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3155 +/- ##
==========================================
+ Coverage 93.15% 93.18% +0.02%
==========================================
Files 376 376
Lines 7353 7353
Branches 204 190 -14
==========================================
+ Hits 6850 6852 +2
+ Misses 503 501 -2
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Dec 10, 2019
Contributor
kailuowang
left a comment
There was a problem hiding this comment.
Smart way to address the breaking changes in the toString of the new collections.
LukaJCB
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't need to happen before 2.1.0 but we should be running these tests on 2.13.