Rename rangeE for clarity#3198
Merged
LukaJCB merged 1 commit intoDec 10, 2019
Merged
Conversation
ChristopherDavenport
approved these changes
Dec 10, 2019
LukaJCB
approved these changes
Dec 10, 2019
kailuowang
approved these changes
Dec 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #3198 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 376 376
Lines 7409 7409
Branches 196 196
=======================================
Hits 6895 6895
Misses 514 514
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one small thing that I just noticed in #3150, but I'd already caused enough trouble there so I decided it'd be best to handle in a follow-up. 😄
I think
rangeEwas named to matchrange, but it doesn't actually create a range, and it's not in any wayEitherspecific, so I replaced it with a generalfromValuesmethod that can be used in these tests.