Fix foldA, reduceA, and reduceMapA short-circuiting#3199
Merged
Conversation
LukaJCB
previously approved these changes
Dec 10, 2019
Contributor
Author
|
I went ahead and added the API docs edits in this PR, hope you don't mind, @LukaJCB. |
Codecov Report
@@ Coverage Diff @@
## master #3199 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 376 376
Lines 7409 7409
Branches 197 191 -6
=======================================
Hits 6895 6895
Misses 514 514
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #3150, the only real reason I can see for
foldAandreduceAto exist is because they can short-circuit, whilefold(fga)(Applicative.monoid)etc. can't. This change fixes them so they actually do short-circuit, and adds some tests to verify this.